Continued Execution Context work and some little fixes #6506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Protect `Image.write` - Correct text on error message.
- Remove context overrides from tests. - Add test for `File` operations in context.
- Fix issue with appending to dry run.
jdunkerley
force-pushed
the
wip/jd/image-write-and-nits
branch
from
0f84e73
to
4030748
Compare
jdunkerley
added
the
CI: No changelog needed
radeusgd
reviewed
May 2, 2023
distribution/lib/Standard/Base/0.0.0-dev/src/System/File_Format.enso
Outdated
Show resolved
Hide resolved
…t.enso Co-authored-by: Radosław Waśko <radoslaw.wasko@enso.org>
radeusgd
reviewed
May 2, 2023
| Test.group "Delimited File Writing" <| Context.Output.with_enabled <| | ||
| Test.group "Delimited File Writing" <| |
There was a problem hiding this comment.
So glad to see all of these gone.
radeusgd
reviewed
May 2, 2023
radeusgd
reviewed
May 2, 2023
radeusgd
reviewed
May 2, 2023
Comment on lines
+418
to
+430
| Test.specify "should perform a dry run appending text to a file if Context.Output is disabled" <| | ||
| f = transient / "work.txt" | ||
| f.delete_if_exists | ||
| "line 1!".write f on_existing_file=Existing_File_Behavior.Append on_problems=Report_Error . should_succeed . should_equal f | ||
|
|
||
| Context.Output.with_disabled <| | ||
| r = '\nline 2!'.write f on_existing_file=Existing_File_Behavior.Append on_problems=Report_Error | ||
| Problems.expect_only_warning Dry_Run_Operation r | ||
| r.exists.should_be_true | ||
| r.read_text.should_equal 'line 1!\nline 2!' | ||
| f.read_text.should_equal 'line 1!' | ||
|
|
||
| Context.Output.with_enabled <| r.delete_if_exists |
radeusgd
reviewed
May 2, 2023
radeusgd
reviewed
May 2, 2023
radeusgd
reviewed
May 2, 2023
radeusgd
reviewed
May 2, 2023
radeusgd
approved these changes
May 2, 2023
There was a problem hiding this comment.
Looks all very good, I'm glad that we are getting this tested.
We need to align the description of the no-backup test with the contents as currently they contradict each other and that is bad - it results in it being unclear what is the expected behaviour - creating a backup or not doing it??
Other than that, some cosmetic comments, low priority so feel free to ignore.
GregoryTravis
approved these changes
May 2, 2023
6 tasks
2 tasks
Procrat
added a commit
that referenced
this pull request
May 3, 2023
* develop: (34 commits) Continued Execution Context work and some little fixes (#6506) IDE's logging to a file (#6478) Fix application config (#6513) Cloud/desktop mode switcher (#6448) Fix doubled named arguments bug (#6422) Reimplement `enso_project` as a proper builtin (#6352) Fix layer ordering between dropdown and breadcrumbs backgrounds. (#6483) Multiflavor layers (#6477) DataflowAnalysis preserves dependencies order (#6493) Implement `create_database_table` for Database Table (#6467) Limit Dead Letter logging (#6482) More reliable shutdown of the EnsoContext to save resources (#6468) Make execution mode `live` default for CLI (#6496) Finishing Vector Editor (#6470) Proper handling of multiple list views. (#6461) Fix disappearing cached shapes (#6458) Add Execution Context control to Text.write (#6459) Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443) Introducing @BuiltinMethod.needsFrame and InlineableNode (#6442) Hide profile button behind a feature flag (#6430) ...
Procrat
added a commit
that referenced
this pull request
May 4, 2023
* develop: Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514) Continued Execution Context work and some little fixes (#6506) IDE's logging to a file (#6478) Fix application config (#6513) Cloud/desktop mode switcher (#6448) Fix doubled named arguments bug (#6422) Reimplement `enso_project` as a proper builtin (#6352) Fix layer ordering between dropdown and breadcrumbs backgrounds. (#6483) Multiflavor layers (#6477) DataflowAnalysis preserves dependencies order (#6493) Implement `create_database_table` for Database Table (#6467) Limit Dead Letter logging (#6482) More reliable shutdown of the EnsoContext to save resources (#6468) Make execution mode `live` default for CLI (#6496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
with_disabledshortcut forContext.Image.writebehindContext.Output.Forbidden_Operationerror message.Fileoperations tests withContext.Outputdisabled.Text.writeoperations withContext.Outputdisabled.File_Formatdropdown widget.Invalid_Format.to_display_text.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.