Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataflowAnalysis preserves dependencies order #6493

Merged
merged 4 commits into from
May 2, 2023
Merged

DataflowAnalysis preserves dependencies order #6493

merged 4 commits into from
May 2, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 1, 2023

Pull Request Description

close #6324

Changelog

  • feat: DataflowAnalysis compiler pass preserves the order of dependencies. This way when attaching the visualization to the sub-expression, the engine can find the first cached parent node, and properly invalidate it.
  • update: runtime visualization test is updated to reproduce the issue

Important Notes

The dropdown for the column "LOCATION" is available right after the Restaurants project startup.

2023-05-01-171700_1386x975_scrot

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 1, 2023
@4e6 4e6 self-assigned this May 1, 2023
@4e6
Merge branch 'develop' into wip/db/6324-dropdown-not-shown-on-a-node-…
0afc15f 
…on-opening-a-simple-project-appears-when-clicked-into
JaroslavTulach
JaroslavTulach approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping order seems like a good idea.

4e6 added 2 commits May 2, 2023 12:32
@4e6
Merge branch 'develop' into wip/db/6324-dropdown-not-shown-on-a-node-…
0dd1737 
…on-opening-a-simple-project-appears-when-clicked-into
@4e6
Merge branch 'develop' into wip/db/6324-dropdown-not-shown-on-a-node-…
dbbcf43 
…on-opening-a-simple-project-appears-when-clicked-into
@4e6 4e6 added CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge labels May 2, 2023
@mergify mergify bot merged commit 84e59f1 into develop May 2, 2023
@mergify mergify bot deleted the wip/db/6324-dropdown-not-shown-on-a-node-on-opening-a-simple-project-appears-when-clicked-into branch May 2, 2023 14:22
@enso-bot enso-bot bot mentioned this pull request May 3, 2023
Closed
Procrat added a commit that referenced this pull request May 3, 2023
@Procrat
Merge branch 'develop' into wip/procrat/json-viz-last-row-6196
b63966e 
* develop: (34 commits)
  Continued Execution Context work and some little fixes (#6506)
  IDE's logging to a file (#6478)
  Fix application config (#6513)
  Cloud/desktop mode switcher (#6448)
  Fix doubled named arguments bug (#6422)
  Reimplement `enso_project` as a proper builtin (#6352)
  Fix layer ordering between dropdown and breadcrumbs backgrounds.  (#6483)
  Multiflavor layers (#6477)
  DataflowAnalysis preserves dependencies order (#6493)
  Implement `create_database_table` for Database Table (#6467)
  Limit Dead Letter logging (#6482)
  More reliable shutdown of the EnsoContext to save resources (#6468)
  Make execution mode `live` default for CLI (#6496)
  Finishing Vector Editor (#6470)
  Proper handling of multiple list views. (#6461)
  Fix disappearing cached shapes (#6458)
  Add Execution Context control to Text.write (#6459)
  Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443)
  Introducing @BuiltinMethod.needsFrame and InlineableNode (#6442)
  Hide profile button behind a feature flag (#6430)
  ...
Procrat added a commit that referenced this pull request May 4, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
9a86a92 
* develop:
  Fix cut-off in text visualisations (#6421)
  Infer correct synthetic name for nested modules (#6525)
  Delete unused websocket dependency (#6535)
  Run typecheck and eslint on `./run lint` (#6314)
  Force pending saves if client closes abruptly (#6514)
  Continued Execution Context work and some little fixes (#6506)
  IDE's logging to a file (#6478)
  Fix application config (#6513)
  Cloud/desktop mode switcher (#6448)
  Fix doubled named arguments bug (#6422)
  Reimplement `enso_project` as a proper builtin (#6352)
  Fix layer ordering between dropdown and breadcrumbs backgrounds.  (#6483)
  Multiflavor layers (#6477)
  DataflowAnalysis preserves dependencies order (#6493)
  Implement `create_database_table` for Database Table (#6467)
  Limit Dead Letter logging (#6482)
  More reliable shutdown of the EnsoContext to save resources (#6468)
  Make execution mode `live` default for CLI (#6496)
@4e6 4e6 mentioned this pull request May 5, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubertp hubertp hubertp approved these changes

@Akirathan Akirathan Akirathan approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

Assignees

@4e6 4e6

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropdown not shown on a node on opening a simple project, appears when clicked into.
4 participants
@4e6 @hubertp @Akirathan @JaroslavTulach