-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating Redshift connector from Database
library into a new AWS
library
#6550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/5777-aws-s3-read
branch
from
May 4, 2023 13:26
20a65ec
to
c47fa2d
Compare
radeusgd
requested review from
jdunkerley,
GregoryTravis,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
May 4, 2023 13:28
JaroslavTulach
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build.sbt
changes are OK from my perspective. Just consider removing truffle-api
dependencies - probably unnecessary.
radeusgd
force-pushed
the
wip/5777-aws-s3-read
branch
from
May 4, 2023 15:08
c47fa2d
to
b8fd393
Compare
GregoryTravis
approved these changes
May 4, 2023
jdunkerley
approved these changes
May 4, 2023
engine/runtime/src/main/scala/org/enso/compiler/phase/ImportResolver.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Related to #5777
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.