Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating Redshift connector from Database library into a new AWS library #6550

Merged
merged 22 commits into from
May 4, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 4, 2023

Pull Request Description

Related to #5777

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this May 4, 2023
@radeusgd
Copy link
Member Author

radeusgd commented May 4, 2023

This PR also adds a widget to Database.connect for choosing the database type.

image
image

We currently use _ placeholders for missing required arguments to show to the user that more are needed. Ideally, we will want to use nested widgets.

@radeusgd radeusgd marked this pull request as ready for review May 4, 2023 13:28
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build.sbt changes are OK from my perspective. Just consider removing truffle-api dependencies - probably unnecessary.

build.sbt Outdated Show resolved Hide resolved
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 4, 2023
@mergify mergify bot merged commit 41a8257 into develop May 4, 2023
@mergify mergify bot deleted the wip/5777-aws-s3-read branch May 4, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants