-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Vector operations shall be applicable on java.util.ArrayList #6642
Conversation
} | ||
} | ||
|
||
@Specialization(replaces = {"executeArray", "executeVector"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could probably enhance the DSL to be able to generate replaces
specializations. We already can do fallback
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I used own Node
is: I wanted to use generic self
- Object
not an Array
. I haven't found a way to do that with a DSL. Moreover there is
we want to be able to have nodes that operate on any array-like object. It is not very useful in case of slice
- we don't use it from engine
itself. However we will benefit from having real nodes that specialize in case of length
and at
.
* develop: Implement loading spinner for visualisations. (#6512) Fix blank input port (#6614) Add `Date_Range` (#6621) All Vector operations shall be applicable on java.util.ArrayList (#6642) Fix redirect paths and enable authentication and new dashboard by default (#6605) Fix #6287: wrong nested breadcrumb ordering (#6617) Whitelist AWS Cognito domains (#6643) Revert "Add COOP+COEP+CORP headers (#6597)" (#6647) Fix shortcuts table formatting (#6644) Automatic type based dropdown does not include singleton in a union type (#6629) Make Meta.get_annotation work for constructor (#6633)
Pull Request Description
Fixes #6609 by
Vector_Spec
onjava.util.ArrayList
Important Notes
Contains additional DSL processor fix:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides