All Vector operations shall be applicable on java.util.ArrayList #6642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
hubertp and
Akirathan
as code owners
jdunkerley
approved these changes
May 11, 2023
radeusgd
reviewed
May 11, 2023
radeusgd
reviewed
May 11, 2023
hubertp
approved these changes
May 11, 2023
| } | ||
| } | ||
|
|
||
| @Specialization(replaces = {"executeArray", "executeVector"}) |
There was a problem hiding this comment.
Could probably enhance the DSL to be able to generate replaces specializations. We already can do fallback.
There was a problem hiding this comment.
The reason why I used own Node is: I wanted to use generic self - Object not an Array. I haven't found a way to do that with a DSL. Moreover there is
we want to be able to have nodes that operate on any array-like object. It is not very useful in case of slice - we don't use it from engine itself. However we will benefit from having real nodes that specialize in case of length and at.
hubertp
approved these changes
May 11, 2023
GregoryTravis
approved these changes
May 11, 2023
GregoryTravis
approved these changes
May 11, 2023
JaroslavTulach
added
the
CI: Ready to merge
Procrat
added a commit
that referenced
this pull request
May 12, 2023
* develop: Implement loading spinner for visualisations. (#6512) Fix blank input port (#6614) Add `Date_Range` (#6621) All Vector operations shall be applicable on java.util.ArrayList (#6642) Fix redirect paths and enable authentication and new dashboard by default (#6605) Fix #6287: wrong nested breadcrumb ordering (#6617) Whitelist AWS Cognito domains (#6643) Revert "Add COOP+COEP+CORP headers (#6597)" (#6647) Fix shortcuts table formatting (#6644) Automatic type based dropdown does not include singleton in a union type (#6629) Make Meta.get_annotation work for constructor (#6633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6609 by
Vector_Speconjava.util.ArrayListImportant Notes
Contains additional DSL processor fix:
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides