Make Meta.get_annotation work for constructor #6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
commented
May 10, 2023
| @@ -277,9 +277,16 @@ spec = | |||
|
|
|||
| Meta.get_annotation value "my_method" "self" . should_equal "self" | |||
|
|
|||
| Meta.get_annotation value "Value" "foo" 7 8 . should_equal 15 | |||
There was a problem hiding this comment.
GregoryTravis
approved these changes
May 10, 2023
JaroslavTulach
added
the
CI: Ready to merge
jdunkerley
approved these changes
May 10, 2023
Akirathan
approved these changes
May 10, 2023
radeusgd
approved these changes
May 10, 2023
Procrat
added a commit
that referenced
this pull request
May 12, 2023
* develop: Implement loading spinner for visualisations. (#6512) Fix blank input port (#6614) Add `Date_Range` (#6621) All Vector operations shall be applicable on java.util.ArrayList (#6642) Fix redirect paths and enable authentication and new dashboard by default (#6605) Fix #6287: wrong nested breadcrumb ordering (#6617) Whitelist AWS Cognito domains (#6643) Revert "Add COOP+COEP+CORP headers (#6597)" (#6647) Fix shortcuts table formatting (#6644) Automatic type based dropdown does not include singleton in a union type (#6629) Make Meta.get_annotation work for constructor (#6633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #6612 by searching for the atom constructor on the
targetitself, not its type.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,