Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shortcuts table formatting #6644

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix shortcuts table formatting #6644

merged 1 commit into from
May 11, 2023

Conversation

Akirathan
Copy link
Member

Just a minor style fixes of shortcuts.md table. Seems like it was broken in 719bd8c

@Akirathan Akirathan added CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge labels May 11, 2023
@farmaazon
Copy link
Contributor

Is this a result of ./run fmt? It should format all md files.

@Akirathan
Copy link
Member Author

Is this a result of ./run fmt? It should format all md files.

Probably. I haven't checked that. I have just seen that the formatting is off, therefore, the preview does not work, and so I fixed it manually.

farmaazon
farmaazon approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So please run ./run fmt and check if formatter changes something before merging.

@mergify mergify bot merged commit a6fdfc7 into develop May 11, 2023
@mergify mergify bot deleted the wip/akirathan/fix-shortcuts-formatting branch May 11, 2023 12:05
Procrat added a commit that referenced this pull request May 11, 2023
@Procrat
Merge branch 'develop' into wip/procrat/wrong-nested-breadcrumb-order…
c1a5cda 
…ing-6287

* develop:
  Fix shortcuts table formatting (#6644)
  Automatic type based dropdown does not include singleton in a union type (#6629)
  Make Meta.get_annotation work for constructor (#6633)
  Limit the number of reported warnings (#6577)
  Add COOP+COEP+CORP headers (#6597)
Procrat added a commit that referenced this pull request May 12, 2023
@Procrat
Merge branch 'develop' into wip/procrat/home-button-6399
5a86e4a 
* develop:
  Implement loading spinner for visualisations. (#6512)
  Fix blank input port (#6614)
  Add `Date_Range` (#6621)
  All Vector operations shall be applicable on java.util.ArrayList (#6642)
  Fix redirect paths and enable authentication and new dashboard by default (#6605)
  Fix #6287: wrong nested breadcrumb ordering (#6617)
  Whitelist AWS Cognito domains (#6643)
  Revert "Add COOP+COEP+CORP headers (#6597)" (#6647)
  Fix shortcuts table formatting (#6644)
  Automatic type based dropdown does not include singleton in a union type (#6629)
  Make Meta.get_annotation work for constructor (#6633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@MichaelMauderer MichaelMauderer Awaiting requested review from MichaelMauderer

@wdanilo wdanilo Awaiting requested review from wdanilo

@mwu-tow mwu-tow Awaiting requested review from mwu-tow

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akirathan @farmaazon