Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor create_database_table into Connection.create_table and select_into_database_table, implement Set. #6925

Merged
merged 25 commits into from
Jun 6, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jun 1, 2023

Pull Request Description

First part for #6498 - refactoring of the upload infrastructure, in preparation for update_database_table.

Implemented a Set data structure which was long needed.

The APIs are added and an initial implementation is created, but it is not complete - but it has grown significantly already so the remaining implementation will be done as a separate PR.

Adds some basic ability for a function to ensure that it is only executed from within a transaction.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this Jun 1, 2023
Base automatically changed from wip/jd/table-write-100 to develop June 1, 2023 22:10
@radeusgd radeusgd force-pushed the wip/radeusgd/6498-update-database-table branch from c060224 to 85754ae Compare June 2, 2023 09:53
@radeusgd radeusgd changed the base branch from develop to wip/radeusgd/6869-simplify-missing-column-error June 2, 2023 09:54
@radeusgd radeusgd force-pushed the wip/radeusgd/6869-simplify-missing-column-error branch from af92a73 to fcae969 Compare June 2, 2023 11:18
Base automatically changed from wip/radeusgd/6869-simplify-missing-column-error to develop June 2, 2023 12:09
@radeusgd radeusgd force-pushed the wip/radeusgd/6498-update-database-table branch from 85754ae to 7056148 Compare June 2, 2023 12:32
@radeusgd radeusgd changed the title Implement Insert for update_database_table, split create_database_table into Connection.create_table and select_into_database_table. Refactor create_database_table into Connection.create_table and select_into_database_table, implement Set. Jun 2, 2023
@radeusgd
Copy link
Member Author

radeusgd commented Jun 2, 2023

I added widgets for selecting a column for the primary_key fields in select_into... but they do not seem to show up :/

image

@radeusgd radeusgd marked this pull request as ready for review June 2, 2023 17:05
@radeusgd
Copy link
Member Author

radeusgd commented Jun 2, 2023

@jdunkerley do you think this could be because the function is an extension function?

Although I'm pretty sure that used to work. Maybe because it is imported with a rename? That would be weird but you never know. Still, ideally I think I'd prefer to figure out this issue as part of the follow-up PR (unless I did some obvious mistake that I'm missing here).

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Set.enso Outdated Show resolved Hide resolved
@radeusgd
Copy link
Member Author

radeusgd commented Jun 5, 2023

The widgets are behaving weirdly

Enso_KsdavNafWb.mp4

I set up a custom @primary_key Widget_Helpers.make_column_name_vector_selector annotation but it seems to be not picked up.

I see both a dropdown for Nothing as well as a Vector Editor plus (I think only one of these 2 should show up for a single parameter, no? in this case vector editor should probably take over, especially as its requested by the widget)

Moreover, when I add an element with Vector Editor - Nothing gets added, even though the Vector is of Text, not Nothing and it has the column selection widget which somehow does not get picked up.

cc: @Frizi

@radeusgd radeusgd force-pushed the wip/radeusgd/6498-update-database-table branch 2 times, most recently from fc87e96 to 1d514e9 Compare June 5, 2023 17:45
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jun 5, 2023
@radeusgd radeusgd force-pushed the wip/radeusgd/6498-update-database-table branch from 1d514e9 to 35570eb Compare June 6, 2023 08:41
@mergify mergify bot merged commit b513839 into develop Jun 6, 2023
@mergify mergify bot deleted the wip/radeusgd/6498-update-database-table branch June 6, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants