-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor create_database_table
into Connection.create_table
and select_into_database_table
, implement Set
.
#6925
Conversation
d2518db
to
ad897c8
Compare
c060224
to
85754ae
Compare
af92a73
to
fcae969
Compare
85754ae
to
7056148
Compare
Insert
for update_database_table
, split create_database_table
into Connection.create_table
and select_into_database_table
.create_database_table
into Connection.create_table
and select_into_database_table
, implement Set
.
@jdunkerley do you think this could be because the function is an extension function? Although I'm pretty sure that used to work. Maybe because it is imported with a rename? That would be weird but you never know. Still, ideally I think I'd prefer to figure out this issue as part of the follow-up PR (unless I did some obvious mistake that I'm missing here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The widgets are behaving weirdly Enso_KsdavNafWb.mp4I set up a custom I see both a dropdown for Moreover, when I add an element with Vector Editor - cc: @Frizi |
fc87e96
to
1d514e9
Compare
…attern match in the in-memory)
1d514e9
to
35570eb
Compare
…outside of a transaction.
Pull Request Description
First part for #6498 - refactoring of the upload infrastructure, in preparation for
update_database_table
.Implemented a
Set
data structure which was long needed.The APIs are added and an initial implementation is created, but it is not complete - but it has grown significantly already so the remaining implementation will be done as a separate PR.
Adds some basic ability for a function to ensure that it is only executed from within a transaction.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.