Avoid Compiler compile time dependency on EnsoContext #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
force-pushed
the
wip/jtulach/CompilerContext
branch
from
392a813
to
fd0a9e7
Compare
JaroslavTulach
commented
Jul 16, 2023
| @@ -446,7 +409,7 @@ public CompilationStage getCompilationStage() { | |||
| * | |||
| * @param compilationStage the new compilation stage for the module. | |||
| */ | |||
| public void unsafeSetCompilationStage(CompilationStage compilationStage) { | |||
| void unsafeSetCompilationStage(CompilationStage compilationStage) { | |||
There was a problem hiding this comment.
I wanted to do this change since I joined Enso. Calling a method unsafe, but exposing it to everyone is a poor design practice. Let's hide it!
The only way to call these unsafe method is to:
- be in the same package
- have access to
CompilerContext.updateModule - use
ModuleTestUtilsin tests
The access control shall make it clear it is not a method for everyone.
Akirathan
reviewed
Jul 17, 2023
|
|
||
| CharSequence getCharacters(Module module) throws IOException; | ||
|
|
||
| void updateModule(Module module, Consumer<Updater> callback); |
There was a problem hiding this comment.
This looks good. It will definitelly help us to, at least, make the modifications to modules atomic.
Akirathan
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Defining
CompilerContextto encapsulate all the existing calls intoEnsoContext. Providing implementation of this interface that delegates toEnsoContext. Allows us to compile theCompilerclass separately fromengine/runtime- after some further work.Important Notes
The ultimate goal remains to create
engine/runtime-compilerproject that would be able to properly apply allIRPasses to theIRcreated byengine/runtime-parser, but it wouldn't need a dependency on the Truffle API and definitely not on theengine/runtimeproject.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,