Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ascribed types & atom_with_hole #7348

Merged
merged 10 commits into from
Jul 24, 2023
Merged

Ascribed types & atom_with_hole #7348

merged 10 commits into from
Jul 24, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jul 20, 2023 •
edited
Loading

Pull Request Description

Fixes #7024 by treating HoleInAtom as always assignable value. Verifies where fill operation provides value of the right type. Checking these special values sooner than checking Type to keep the speed of sieve1.enso benchmark even while it "gets typed".

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • Existing benchmarks don't regress

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 20, 2023
@JaroslavTulach JaroslavTulach self-assigned this Jul 20, 2023
@enso-bot enso-bot bot mentioned this pull request Jul 21, 2023
Closed
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/MetaWithHoleTyped_7024 branch from f09bc62 to bb48115 Compare July 21, 2023 09:32
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Jul 21, 2023 •
edited
Loading

Running official benchmarks to see the effect on sieve benchmark. Looks like there is a slowdown. Running one more benchmark. If it confirms the slowdown, then I keep the original version of sieve1 and create sieve2 with ascribed type check.

@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/MetaWithHoleTyped_7024 branch from ab9fe1e to 1caeafd Compare July 22, 2023 08:26
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jul 22, 2023
@JaroslavTulach
Copy link
Member Author

a8d49c returns the sieve1.enso file back into the original state. Running benchmarks again.

@enso-bot enso-bot bot mentioned this pull request Jul 24, 2023
Closed
@JaroslavTulach JaroslavTulach merged commit 34c63e3 into develop Jul 24, 2023
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/MetaWithHoleTyped_7024 branch July 24, 2023 05:03
@enso-bot enso-bot bot mentioned this pull request Jul 26, 2023
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Sep 12, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@4e6 4e6 4e6 approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime argument checks and atom_with_hole don't work together
4 participants
@JaroslavTulach @4e6 @radeusgd @GregoryTravis