-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GraalVM distribution download on MacOS #7364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised we haven't seen some failures before this fix.
I should have asked for QA on MacOS. I have only asked for QA on Windows. That is why I have not spotted this error. Until this is solved, I believe that also nightly builds for MacOS will be failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks build in another place, see the run results:
/Users/runner/work/enso/enso/built-distribution/enso-engine-2023.2.1-dev-macos-amd64/enso-2023.2.1-dev/bin/enso: No such file or directory
I think I have just discovered the problems with the IDE building. It seems that I have accidentally broken |
e980f62
to
dea650e
Compare
Pull Request Description
Follow-up of recent GraalVM update #7176 that fixes downloading of GraalVM for Mac - instead of "darwin", the releases are now named "macos"
Important Notes
Also re-enables the JDK/GraalVM version check as onLoad hook to the
sbt
process. We used to have that check a long time ago. Provides errors like this one if thesbt
is run with a different JVM version:Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.