-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclusive context policy ensures EnsoContext.get returns compilation constant #7493
Conversation
There is a discussion about ContextReference at GraalVM slack. Technically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very cool. Not only the performance might be better, but also some asserts should stop failing.
import org.junit.BeforeClass; | ||
import org.junit.Test; | ||
|
||
public class SharedEngineTest extends TestBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test taken from branch wip/jtulach/NoTypeInNodePlease_6809. The test seems to pass OK with EXCLUSIVE
context policy.
SharedEngineTest fails on the CI trying to download an edition. Probably an |
DebuggingEnsoTest asserts - fixed in d1b5913 |
The first Benchmark results were not good, but the second benchmark results are sane. Running 3rd benchmark results to confirm the result. I think the results are OK and we can integrate. |
Pull Request Description
Fixes #6809 by giving up on any attempt to share
Node
among multipleContext
via sharing a singleEngine
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
SharedContextTest
is passing