Correctly display connections to lambdas #7550
Conversation
vitvakatu
requested review from
MichaelMauderer,
farmaazon,
kazcw,
Frizi and
mwu-tow
as code owners
| .add_leaf(4, 1, node::Kind::argument(), InfixCrumb::RightOperand) | ||
| .add_empty_child(5, Append) | ||
| .done() | ||
| .done() |
There was a problem hiding this comment.
Please add also a test case for lambda like a -> b -> a + b
| SpanSeed::Child(ast::SpanSeedChild { node }) => { | ||
| let kind = node::Kind::argument().with_removable(false); | ||
| let node = node.generate_node(kind, context); | ||
| node.map(|node| node.size.as_usize()) | ||
| } |
There was a problem hiding this comment.
Do I understand correctly that we generate node only to discard it and read its size?
Are there no better options for measuring new AST node size? Like repr_len or char_count in the old AST? I believe generating span tree does much more things.
There was a problem hiding this comment.
Yep, repr_len is better here, thanks for noting. I changed the code.
| /// Both the lambda argument and the `->` token, as a single [`node::Kind::Token`] node. | ||
| child: node::Child, |
There was a problem hiding this comment.
I'm a little afraid of the consequences of folding all arguments and the arrow together into a single token. That means we won't be able to create any useful widgets there, like the ability to add more arguments or apply custom styling. But I guess we can expand this logic once we need it, and likely the span-tree will be removed at this point anyway. So I think it's fine as is.
There was a problem hiding this comment.
Keep in mind that we were not planning to support connections to lambdas at all, so yes, let's think about it when the time comes :)
🌈 QA Passed 🟢Nice work! |
Pull Request Description
Closes #7261
It's impossible to connect to the lambda arguments, but they are displayed as in code, and the correct span tree is generated for the lambda body. (hence you can connect to items inside)
Kapture.2023-08-10.at.16.35.32.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.