Add support for https and wss #7937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
hubertp
force-pushed
the
wip/hubert/7839-https-wss
branch
2 times, most recently
from
9282cc1
to
1641bcf
Compare
JaroslavTulach
approved these changes
Oct 4, 2023
lib/scala/json-rpc-server/src/test/java/org/enso/jsonrpc/SSLContextBuilderTest.java
Show resolved
Hide resolved
4e6
approved these changes
Oct 9, 2023
...ne/language-server/src/main/scala/org/enso/languageserver/boot/LanguageServerComponent.scala
Show resolved
Hide resolved
Preliminary support for https and wss. During language server startup we will read the application config and search for the `https` config with necessary env vars set. The configuration supports two modes of creating ssl-context - via PKCS12 format and certificat+private key. Fixes #7839.
Generic improvements along with actual tests.
Co-authored-by: Dmitry Bushev <bushevdv@gmail.com>
hubertp
force-pushed
the
wip/hubert/7839-https-wss
branch
from
4920667
to
79c0e56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Preliminary support for https and wss. During language server startup we will read the application config and search for the
httpsconfig with necessary env vars set.The configuration supports two modes of creating ssl-context - via PKCS12 format and certificat+private key.
Fixes #7839.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.