Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic XML support #7947

Merged
merged 66 commits into from
Oct 6, 2023
Merged

Basic XML support #7947

merged 66 commits into from
Oct 6, 2023

Conversation

GregoryTravis
Copy link
Contributor

@GregoryTravis GregoryTravis commented Oct 2, 2023

Pull Request Description

This PR includes

  • Reading XML from a file, stream, or string
  • Reading XML via Data.fetch
  • Accessing the root element, element children, and attributes
  • Accessing tag text contents
  • Get tags by name
  • Inner / Outer XML string

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

If you could please add one slight suggeste change in the tests it would make the test case more 'full', and I'm just curious what's the behaviour there 🙂

Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

Some suggested changes and you need to check how XML Doc and Element are rendered in the Table view.

@GregoryTravis
Copy link
Contributor Author

to_display_string and to_js_object:

Screen Shot 2023-10-05 at 10 51 00 AM Screen Shot 2023-10-05 at 10 51 19 AM

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Oct 6, 2023
@mergify mergify bot merged commit 9ba7be2 into develop Oct 6, 2023
30 checks passed
@mergify mergify bot deleted the wip/gmt/7739-xml branch October 6, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for reading XML Files
3 participants