Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Previous_Value in fill_nothing and fill_missing #8105

Merged
merged 9 commits into from
Oct 20, 2023

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 18, 2023

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd self-assigned this Oct 18, 2023
@radeusgd
Copy link
Member Author

image
image

@radeusgd
Copy link
Member Author

image
image
image

@radeusgd radeusgd marked this pull request as ready for review October 18, 2023 17:14
@radeusgd radeusgd force-pushed the wip/radeusgd/fill-nothing-with-previous branch from 3869996 to e8a647f Compare October 18, 2023 17:35
Base automatically changed from wip/radeusgd/8046-column-ref to develop October 18, 2023 19:03
Comment on lines 2452 to 2454
table_ref = Table_Ref.from self
resolved_term = table_ref.resolve term
resolved_new_text = table_ref.resolve new_text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought (and I know I designed this...) but we could make at/get allow a Column_Ref?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but what benefits would that give? at already takes a column name as Text, Column_Ref is useful when we want to distinguish a column name/index from a text/int value, but there is no such risk in at.

And I don't think we ever expect users to manually create a Column_Ref - I think they mostly should rely on just dropdowns.


Still, we can allow it to make it more 'robust'. But then I think we need to allow it in all the other places - like select_columns, Aggregate_Column etc. - wherever a Text/Integer column name/index is expected - to be consistent.

IMHO there is no need for that, but happy to be proven wrong

@radeusgd radeusgd force-pushed the wip/radeusgd/fill-nothing-with-previous branch from e8a647f to 7ecbe68 Compare October 19, 2023 09:12
@radeusgd radeusgd added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Oct 20, 2023
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 20, 2023
@mergify mergify bot merged commit 8172896 into develop Oct 20, 2023
34 of 36 checks passed
@mergify mergify bot deleted the wip/radeusgd/fill-nothing-with-previous branch October 20, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants