-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Previous_Value
in fill_nothing
and fill_missing
#8105
Conversation
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
3869996
to
e8a647f
Compare
table_ref = Table_Ref.from self | ||
resolved_term = table_ref.resolve term | ||
resolved_new_text = table_ref.resolve new_text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought (and I know I designed this...) but we could make at
/get
allow a Column_Ref
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but what benefits would that give? at
already takes a column name as Text, Column_Ref
is useful when we want to distinguish a column name/index from a text/int value, but there is no such risk in at
.
And I don't think we ever expect users to manually create a Column_Ref
- I think they mostly should rely on just dropdowns.
Still, we can allow it to make it more 'robust'. But then I think we need to allow it in all the other places - like select_columns
, Aggregate_Column
etc. - wherever a Text/Integer column name/index is expected - to be consistent.
IMHO there is no need for that, but happy to be proven wrong
e8a647f
to
7ecbe68
Compare
Pull Request Description
Previous_Value
tofill_nothing
andfill_empty
, as requested by Small Libs Tickets for July #7192.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.