-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to default visualization based on type, when no viz has been explicitly set #8389
Conversation
spent way too long debugging an issue caused by me, when i haven't checked GUI1 but am assuming this must break compatibility with it, as the original impl lacked nullable |
merged develop into this branch because GitHub says there were conflicts (probably due to the moved files), but merge-ort had no issues |
Pull Request Description
<expr>.default_visualization
to query the engine for the correct fallback typeinputType
- first for an exact match, then falling back toAny
(i.e. the text/JSON visualization)Important Notes
Contains pretty significant refactors of
VisualizationMetadata
to allow it to be unset.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If GUI codebase was changed, the GUI was tested when built using./run ide build
.