Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic dropdowns #8455

Merged

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Based on work in #8400

Kapture.2023-12-04.at.20.02.09.mp4

I’m not sure the implementation is fully correct, but at least it works for simple cases and allows to test #8400.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the -gui label Dec 4, 2023
@vitvakatu vitvakatu self-assigned this Dec 4, 2023
@vitvakatu vitvakatu requested a review from Frizi as a code owner December 4, 2023 16:04
@vitvakatu vitvakatu merged commit 94d04cf into wip/vitvakatu/widget-configuration Dec 5, 2023
30 of 34 checks passed
@vitvakatu vitvakatu deleted the wip/vitvakatu/dynamic-dropdown branch December 5, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants