Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow language #8512
Arrow language #8512
Changes from 32 commits
6755164
29b7ce6
2c80897
29ed745
3a66ce1
fc68ca0
fd138b2
f01ea3a
6446bd1
e451806
67ba40d
5147628
c13efb0
f52cbd3
7381959
88c80ab
ab3cee8
e9c1d0b
6411d60
1ac4557
393b465
9dbe881
caefb7a
9462066
f5855e7
2e8d7cb
fbb0ee4
431bd5c
81de77f
52bae38
f5a161d
a01b9c0
2cb5cf4
368d5b0
7abe3da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to explicitly specify
internal = true
. By defaultinternal = false
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ArrowLanguage
shall be an experimental feature accessible viaforeign arrow xyz = """
syntax. I am afraid the language needs to be non-internal to be exposed in theforeign
set of language (as of #7882).In any case, it'd be good if
ArrowLanguage
wasn't accessible by default (throw a parsing error for example). Possibly shield it with