Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using cached bindings when the module isn't loaded from cache #8669

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Jan 4, 2024

Pull Request Description

Fixes #8421.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Manually tested.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 4, 2024
@JaroslavTulach JaroslavTulach self-assigned this Jan 4, 2024
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Jan 4, 2024

I have manually verified that the failing reproducer now works:

enso$ rm -rf *; git checkout -f .
enso$ git log | head -n5
commit a1207e029d7780a54a6d09ca2665f7370493b4f8
Author: Radosław Waśko <radoslaw.wasko@enso.org>
Date:   Thu Jan 4 04:57:05 2024 +0100

    Unify `File_Format_Metadata` with `File_For_Read` (#8628)
enso$ sbt --java-home /graalvm buildEngineDistribution
enso$ rm built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/lib/Standard/Database/0.0.0-dev/.enso/cache/ir/0.0.0-dev/Standard/Database/Connection/SQLite_Format.ir
$ rm -rf ~/.local/share/enso/cache/ir/
enso$ ./built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso --in-project test/Table_Tests/ --run test/Table_Tests/src/IO/Formats_Spec.enso 
[WARN] [2024-01-04T06:40:00+01:00] [org.enso.librarymanager.local.DefaultLocalLibraryProvider] Local library search path [***/libraries] does not exist.
[WARN] [2024-01-04T06:40:03+01:00] [enso.org.enso.interpreter.caches.ModuleCache] Unable to load a cache [Standard.Database.Connection.SQLite_Format]: enso/built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/lib/Standard/Database/0.0.0-dev/.enso/cache/ir/0.0.0-dev/Standard/Database/Connection/SQLite_Format.ir
Various File Format support on Table:  [6/6, 1549ms]
    - should be able to be written as CSV, Excel [623ms]
    - should be able to be written as JSON using Table.write [423ms]
    - should write JSON tables [254ms]
    - should append to JSON tables [177ms]
    - should fail to append to JSON non-arrays [32ms]
    - should fail gracefully when provided with an unsupported format [36ms]
Writing to csv files:  [3/3, 620ms]
    - should write to a temporary csv file part of the data if context is disabled [270ms]
    - should create a backup file if overwriting [118ms]
    - should support appending [232ms]
Writing to json files:  [3/3, 992ms]
    - should write to a temporary json file part of the data if context is disabled [920ms]
    - should create a backup file if overwriting [33ms]
    - should support appending [37ms]
12 tests succeeded.
0 tests failed.
0 tests skipped.
0 groups of tests skipped.

@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jan 4, 2024
@JaroslavTulach JaroslavTulach merged commit 8396bfa into develop Jan 5, 2024
34 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/Caches_8421 branch January 5, 2024 07:03
@radeusgd
Copy link
Member

radeusgd commented Jan 8, 2024

Thanks so much for fixing this! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a cache file causes run-time compiler error to be thrown
4 participants