Executing (parts of) Truffle TCK with Enso values #8685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
4e6
approved these changes
Jan 5, 2024
...ruments/src/main/java/org/enso/interpreter/test/instruments/tck/EnsoTckLanguageProvider.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/java/org/enso/interpreter/test/tck/EnsoTckErrorTypeTest.java
Show resolved
Hide resolved
|
Looks like we have 500+ more tests and five failures to fix. |
|
7312324 is the first fix done to align Enso with the behavior expected by TCK. |
|
There is this Cannot load edition 2024.1.1-dev error which is not happening locally. Any ideas what it is caused by? CCing @hubertp , @Akirathan, @mwu-tow Trying to mimic the problem with: 77deb71 - should be the fix. |
|
Great now the tests run fine and we can see real TCK failures. There are problems with:
|
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis and
AdRiley
as code owners
radeusgd
reviewed
Jan 10, 2024
...in/java/org/enso/interpreter/node/expression/builtin/interop/syntax/HostValueToEnsoNode.java
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Jan 10, 2024
JaroslavTulach
commented
Jan 11, 2024
| plus a b = a + b | ||
| """).invokeMember("eval_expression", "plus"); | ||
|
|
||
| return List.of( |
There was a problem hiding this comment.
Ideally we want to expand these values, expressions, constructors, etc. to cover other Enso types - not just NUMBER and STRING.
1 task
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2024
Since #8685, there is the following error (warning) message from JPMS plugin when building `runtime-test-instruments`: ``` [error] Returned (10): Vector(/home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/nativeimage/23.1.0/nativeimage-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/word/23.1.0/word-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/jniutils/23.1.0/jniutils-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/collections/23.1.0/collections-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/polyglot/polyglot/23.1.0/polyglot-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-api/23.1.0/truffle-api-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-runtime/23.1.0/truffle-runtime-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/truffle/truffle-compiler/23.1.0/truffle-compiler-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/graalvm/sdk/polyglot-tck/23.1.0/polyglot-tck-23.1.0.jar, /home/pavel/.cache/coursier/v1/https/repo1.maven.org/maven2/org/netbeans/api/org-openide-util-lookup/RELEASE180/org-openide-util-lookup-RELEASE180.jar) [error] Expected: (13): List(org.graalvm.sdk:nativeimage:23.1.0, org.graalvm.sdk:word:23.1.0, org.graalvm.sdk:jniutils:23.1.0, org.graalvm.sdk:collections:23.1.0, org.graalvm.polyglot:polyglot:23.1.0, org.graalvm.truffle:truffle-api:23.1.0, org.graalvm.truffle:truffle-runtime:23.1.0, org.graalvm.truffle:truffle-compiler:23.1.0, org.graalvm.sdk:polyglot-tck:23.1.0, org.graalvm.truffle:truffle-tck:23.1.0, org.graalvm.truffle:truffle-tck-common:23.1.0, org.graalvm.truffle:truffle-tck-tests:23.1.0, org.netbeans.api:org-openide-util-lookup:RELEASE180) ``` This PR removes this error message by providing appropriate `libraryDependencies` to `runtime-test-instruments`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Initial steps to fix #5238. With a little work we have more than two hundred of new tests verifying if Enso values behave as good Truffle citizens and support polyglot interop the right way.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides. All code has been tested:
EqualsNode