Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Native aarch64 macOS builds, refactoring #8864

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Conversation

mwu-tow
Copy link
Contributor

@mwu-tow mwu-tow commented Jan 25, 2024

Pull Request Description

This PR adds native aarch64 target to our release process.

It also includes refactoring of workflow generation and minor tweaks:

  • removing some workarounds in the generated action code that are not needed anymore;
  • some version bumps that are harmless;
  • benchmarks and release builds have cleaning enabled unconditionally.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@mwu-tow mwu-tow linked an issue Jan 29, 2024 that may be closed by this pull request
@mwu-tow mwu-tow added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 29, 2024
@mwu-tow mwu-tow self-assigned this Jan 29, 2024
@mwu-tow mwu-tow marked this pull request as ready for review January 29, 2024 10:09
Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 1 line change in app/ide-desktop/ is to electron-builder code.

@mwu-tow
Copy link
Contributor Author

mwu-tow commented Jan 29, 2024

Note: Not resolving conflicts at the moment intentionally, this should not affect the review.

@mwu-tow mwu-tow merged commit 9a2bb19 into develop Feb 1, 2024
17 of 19 checks passed
@mwu-tow mwu-tow deleted the wip/mwu/aarch64-macos-ci branch February 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native aarch64 macOS builds.
2 participants