-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SourceDocument for text edit support #8957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
added
CI: No changelog needed
Do not require a changelog entry for this PR.
-gui
labels
Feb 3, 2024
kazcw
requested review from
Frizi,
farmaazon,
MichaelMauderer and
vitvakatu
as code owners
February 3, 2024 02:56
farmaazon
approved these changes
Feb 6, 2024
import { print, type AstId, type Module, type ModuleUpdate } from '.' | ||
import { rangeEquals, sourceRangeFromKey, type SourceRange } from '../yjsModel' | ||
|
||
export class SourceDocument { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some docs about this class, it will help to read the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-gui
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Introduce
SourceDocument
, a reactive source code representation that can be synced from aMutableModule
.SourceDocument
replaces various logic for tracking source code and spans--most importantly,ReactiveModule
. There is no longer any reactively-trackedModule
, per-se: Changes to theMutableModule
attached to the synchronizedydoc
are pushed as Y.Js events to theSourceDocument
andGraphDb
, which are reactively tracked. This avoids a problem in the upcoming text-synchronization (next PR) that was caused by a reactive back channel bypassing theGraphDb
and resulting in observation of inconsistent states.Stacked on #8956. Part of #8238.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.