Fix vector widget in non-argument literal #8972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
CI: No changelog needed
farmaazon
requested review from
Frizi,
MichaelMauderer,
vitvakatu and
kazcw
as code owners
vitvakatu
approved these changes
Feb 5, 2024
| return props.input.value.children().next().value.code === '[' ? Score.Perfect : Score.Mismatch | ||
| else return Score.Mismatch | ||
| else if (props.input.value instanceof Ast.Ast) { | ||
| return props.input.value.children().next().value.code() === '[' |
There was a problem hiding this comment.
Gosh, I was looking at this line for the whole minute, really hard to notice.
Frizi
approved these changes
Feb 5, 2024
MichaelMauderer
pushed a commit
that referenced
this pull request
Feb 6, 2024
Fix vector widget not appearing in non-argument list literals. Added tests for showing widgets for various literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix vector widget not appearing in non-argument list literals. Added tests for showing widgets for various literals.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.