Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change empty_error type to array. Add tests #9019

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Feb 10, 2024

Pull Request Description

Now empty_error takes a type we can give a more accurate error message here.

I also added some tests and enabled a test that was disabled on windows. (It runs on my windows machine so don't know why it shouldn't be turned on)

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 10, 2024
@AdRiley AdRiley mentioned this pull request Feb 10, 2024
5 tasks
@AdRiley AdRiley merged commit 48a61d7 into develop Feb 12, 2024
25 of 27 checks passed
@AdRiley AdRiley deleted the wip/adr/change-empty-error-to-array branch February 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants