Update the aggregate API to take a separate group_by
#9027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdunkerley
requested review from
radeusgd,
GregoryTravis and
AdRiley
as code owners
|
Still to do tests but marking as ready for review so people can comment and look over. |
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Deprecated.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Errors/Deprecated.enso
Outdated
Show resolved
Hide resolved
jdunkerley
requested review from
Frizi,
farmaazon,
MichaelMauderer,
vitvakatu and
kazcw
as code owners
jdunkerley
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 12, 2024
radeusgd
reviewed
Feb 12, 2024
GregoryTravis
approved these changes
Feb 12, 2024
| type Validated_Aggregate_Columns | ||
| ## PRIVATE | ||
| Value (key_columns:(Vector Column)) (valid_columns:(Vector (Pair Text Aggregate_Column))) (problems:(Vector Any)) | ||
| Value (key_columns:(Vector Column)) (valid_columns:(Vector (Pair Text Aggregate_Column))) (problems:(Vector Any)) (old_style:Boolean=False) |
There was a problem hiding this comment.
At this point we might want to start creating tasks to remind us to remove deprecated things at some point in the future.
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Database/0.0.0-dev/src/Data/Table.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 12, 2024
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Aggregate_Column_Helper.enso
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Feb 12, 2024
jdunkerley
force-pushed
the
wip/jd/aggregate-refactor
branch
from
b8a531a
to
db049f0
Compare
AdRiley
reviewed
Feb 13, 2024
| if new_columns.is_empty then handle_no_output_columns else | ||
| result = self.updated_context_and_columns new_ctx new_columns subquery=True | ||
| if validated.old_style.not then result else | ||
| Warning.attach (Deprecated.Warning "Standard.Database.Data.Table.Table" "aggregate" "Deprecated: The aggregate API has been altered to take the group_by as a separate vector.") result |
There was a problem hiding this comment.
Suggested change
| Warning.attach (Deprecated.Warning "Standard.Database.Data.Table.Table" "aggregate" "Deprecated: The aggregate API has been altered to take the group_by as a separate vector.") result | |
| Warning.attach (Deprecated.Warning "Standard.Database.Data.Table.Table" "aggregate" "Deprecated: The aggregate component has been altered to take the group_by as a separate vector. This component should be rebuilt.") result |
Is that more GUI user friendly? API sounded unfriendly and it didn't tell the user what they should do.
| @@ -240,7 +240,7 @@ raise_duplicated_primary_key_error source_table primary_key original_panic = | |||
| False -> | |||
| row = materialized.first_row.to_vector | |||
| example_count = row.first | |||
| example_entry = row.drop 1 | |||
| example_entry = row.drop (Last 1) | |||
There was a problem hiding this comment.
I don't understand this change.
There was a problem hiding this comment.
The count column moved from first to last column due to API change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Separate out the
Group_Byfrom the column definition inaggregate.Supports the old API with a warning attached about deprecation:
Widgets have been updated with
Group_Byremoved from the dropdown.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.