Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to refactor Storage and Operations #9076

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Conversation

jdunkerley
Copy link
Member

Pull Request Description

Cleaning up some of the structures in Storage before working on UnaryOperations.

  • Removed some legacy code: countMask, Index and DefaultIndex.
  • Renamed mask to applyFilter on Column and Storage.
  • Renamed Table.mask to Table.filter.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 15, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Feb 15, 2024
@mergify mergify bot merged commit f2d2f73 into develop Feb 15, 2024
27 of 29 checks passed
@mergify mergify bot deleted the wip/jd/separate-operators branch February 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants