Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid excessive logging during development #9101

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Feb 20, 2024

Pull Request Description

Closes #9036.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have continue to work

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 20, 2024
@JaroslavTulach JaroslavTulach self-assigned this Feb 20, 2024
@radeusgd
Copy link
Member

radeusgd commented Feb 20, 2024

Thanks for addressing this.

You also reminded me that I wanted to report a related issue:

When I run a very simple Enso program, e.g.

main = 42

I get:

> .\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\bin\enso --run .\test.enso
[WARN] [2024-02-20T12:04:21+01:00] [enso.org.enso.interpreter.runtime.SerializationPool] Serialization of module `test` failed: Unable to write cache data for test.`
42

I don't think users should be seeing such a warning when 'just' running a 'standalone' script.

Do you think we could solve it with this PR as well or shall I rather create a separate ticket for it?

(Also nitpick: the ` at the end of the message is unpaired.)

@4e6
Copy link
Contributor

4e6 commented Feb 20, 2024

> .\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\bin\enso --run .\test.enso
[WARN] [2024-02-20T12:04:21+01:00] [enso.org.enso.interpreter.runtime.SerializationPool] Serialization of module `test` failed: Unable to write cache data for test.`
42

@radeusgd I think it's an issue with the runner script. Can you please create a ticket and assign it to me? I'll take a look later

@JaroslavTulach JaroslavTulach merged commit 462c968 into develop Feb 20, 2024
26 of 29 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/LessLogs_9036 branch February 20, 2024 12:49
@radeusgd
Copy link
Member

radeusgd commented Feb 20, 2024

> .\built-distribution\enso-engine-0.0.0-dev-windows-amd64\enso-0.0.0-dev\bin\enso --run .\test.enso
[WARN] [2024-02-20T12:04:21+01:00] [enso.org.enso.interpreter.runtime.SerializationPool] Serialization of module `test` failed: Unable to write cache data for test.`
42

@radeusgd I think it's an issue with the runner script. Can you please create a ticket and assign it to me? I'll take a look later

Sure, created #9109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of warning logs after changing code followed by buildStdLibAll
4 participants