Refactoring Table.set for GUI2 and other GUI fixes
#9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `expr` function to create an Expression. - Adjust `set` to take `Expression` and allow creation of constant text values. - Removing `Column_Ref.Expression` in favour of `Expression.Value` and adjust signatures to allow both.
Rename `new_name` to `as` on `Table.set`.
Rename name_column to names in cross_tab.
jdunkerley
requested review from
radeusgd,
GregoryTravis and
AdRiley
as code owners
radeusgd
reviewed
Feb 21, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Text/Regex.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Feb 21, 2024
radeusgd
reviewed
Feb 21, 2024
Comment on lines
+14
to
+15
| ## Defines a simple expression based off an input column and an operation to perform. | ||
| type Simple_Expression |
There was a problem hiding this comment.
A bit unsure about the name (I was confused what's the difference between Expression and Simple_Expression).
I think the old Derived_Column or something similar was better describing what this is (or I just got used to it).
There was a problem hiding this comment.
Chosen in discussion with Ned and Sylwia in the product review.
radeusgd
approved these changes
Feb 21, 2024
AdRiley
reviewed
Feb 21, 2024
distribution/lib/Standard/Table/0.0.0-dev/src/Internal/Expand_Objects_Helpers.enso
Show resolved
Hide resolved
AdRiley
reviewed
Feb 21, 2024
AdRiley
approved these changes
Feb 21, 2024
Couple of PR comments.
Fix a load of failing tests.
Add defaults so errors less when you pick a Simple_Expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
regexfunction toStandard.Baseas a way to easily and cleanly make regular expressions.exprandExpression.Valueto distinguish expressions from text values.Table.joinwidget so dropdown exists.Table.filter_by_expressionand allowTable.filterto take anExpression.Simple_Expressionand deprecatedColumn_Operation. Changes the order so takes a column then a calculation.columntovalueandnew_nametoasonTable.set.name_columntonamesonTable.cross_tab.Column_Ref.Expressionin favour of usingExpression.Value.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.