Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark run build #9220

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix benchmark run build #9220

merged 1 commit into from
Feb 29, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Feb 29, 2024

Fixes a regression introduced by #9134

Pull Request Description

Make sure that sbt is invoked only if there are some tasks to run. If not, sbt all is invoked, which fails, as all is not a command.

Important Notes

The first Engine Benchmarks job failure is in https://github.com/enso-org/enso/actions/runs/8073012762/job/22055882533#step:8:923

Benchmark Standard Libraries are failing since the same time, and on the same error, for example at https://github.com/enso-org/enso/actions/runs/8073051776/job/22056002795

Checklist

  • Make sure that (dry-run) benchmarks are fine

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Feb 29, 2024
@Akirathan Akirathan self-assigned this Feb 29, 2024
@Akirathan
Copy link
Member Author

Akirathan commented Feb 29, 2024

Dry-run engine benchmarks scheduled at https://github.com/enso-org/enso/actions/runs/8094436748

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label Feb 29, 2024
@Akirathan Akirathan merged commit c2842df into develop Feb 29, 2024
29 of 31 checks passed
@Akirathan Akirathan deleted the wip/akirathan/fix-bench-build branch February 29, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants