Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup of secrets in tests #9254

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Mar 4, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 4, 2024
@radeusgd radeusgd self-assigned this Mar 4, 2024
@radeusgd radeusgd changed the title Fix cleanup of secrets Fix cleanup of secrets in tests Mar 4, 2024
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Mar 4, 2024
@mergify mergify bot merged commit 5d00a61 into develop Mar 4, 2024
28 of 30 checks passed
@mergify mergify bot deleted the wip/radeusgd/secrets-cleanup branch March 4, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants