Added table.from_union and respective tests #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cassandra-Clark
requested review from
jdunkerley,
radeusgd,
GregoryTravis and
AdRiley
as code owners
jdunkerley
requested changes
Mar 11, 2024
test/Table_Tests/src/Common_Table_Operations/Join/From_Union_Spec.enso
Outdated
Show resolved
Hide resolved
GregoryTravis
approved these changes
Mar 11, 2024
radeusgd
reviewed
Mar 12, 2024
radeusgd
reviewed
Mar 12, 2024
test/Table_Tests/src/Common_Table_Operations/Join/Union_Spec.enso
Outdated
Show resolved
Hide resolved
jdunkerley
approved these changes
Mar 12, 2024
Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
Added comment to document ... operator
Cassandra-Clark
force-pushed
the
9307-add-a-tablefrom_union-method
branch
from
dcdd64c
to
5697317
Compare
|
You need to run
|
Cassandra-Clark
requested review from
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
| ../../content/src/index.html |
There was a problem hiding this comment.
uh oh... i can't tell what happened here from the github ui, but chances are it's the classic "windows turned the symlink into a not symlink"
There was a problem hiding this comment.
Think this is fixed now
There was a problem hiding this comment.
weird... seems like prettier thinks that file is HTML and overwrites it, you might have to manually git checkout develop app/ide-desktop/lib/dashboard/src/index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Table.from_union creates a new table when passed in a vector of tables. This is especially helpful when a grouped method is run multiple times, as it can create a unified result set.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.