Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getters serialization #9480

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 19, 2024

Pull Request Description

close #9429

Changelog:

  • fix: serialization of getter methods

Important Notes

Returns a correct suggestion for the count getter

{
  "type":"Add",
  "id":248,
  "suggestion":{
    "type":"method",
    "module":"Standard.Base.Data.Index_Sub_Range",
    "name":"count",
    "arguments":[
      {
        "name":"self",
        "reprType":"Standard.Base.Data.Index_Sub_Range.Index_Sub_Range",
        "isSuspended":false,
        "hasDefault":false,
        "defaultValue":null,
        "tagValues":null
      }
    ],
    "selfType":"Standard.Base.Data.Index_Sub_Range.Index_Sub_Range",
    "returnType":"Standard.Base.Data.Numbers.Integer",
    "isStatic":false,
    "annotations":[ ]
  }
}

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 19, 2024
@4e6 4e6 self-assigned this Mar 19, 2024
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Mar 19, 2024
@mergify mergify bot merged commit d21cdb2 into develop Mar 19, 2024
42 checks passed
@mergify mergify bot deleted the wip/db/9429-non-existent-methods-on-integer branch March 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component Browser appears to suggest non-existent methods on Integer
2 participants