remove unused rust modules #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
added
the
CI: No changelog needed
Frizi
requested review from
mwu-tow,
farmaazon,
kazcw,
vitvakatu and
JaroslavTulach
as code owners
Frizi
commented
Mar 25, 2024
| @@ -41,7 +41,6 @@ impl DocParser { | |||
| } | |||
|
|
|||
| /// Parse the documentation. | |||
| #[profile(Detail)] | |||
There was a problem hiding this comment.
This was the ONLY remaining usage of the enso-profiler, so I just removed it. We don't need this anymore, since we use the parse function directly anyway, and the whole profiler machinery was effectively abandoned once we removed old gui.
kazcw
approved these changes
Mar 25, 2024
mwu-tow
approved these changes
Mar 26, 2024
Frizi
commented
Mar 26, 2024
| .collect_vec(); | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
Changes in LS tools caused by removal of itertools from prelude. That was one of the last remaining usages, and it was trivial to replace.
hubertp
approved these changes
Mar 26, 2024
JaroslavTulach
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes a bulk of rust crates that we no longer need, but that added significant install, build and testing time to the Rust parser.
Most significantly, removed
enso-webandenso-shapely, and got rid of many no longer necessary#![feature]s. Moved two still used proc-macros from shapely to prelude. The last remaining usage ofweb-sysis within the logger (console.log), but we may actually want to keep that one.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.