-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Standard.Table. #9559
Conversation
Merge Report_Unmatched into Constants.
Moving Column_Ref, Data_Formatter, Match_Columns, Row.
…nd Simple_Calculation. Moved Table_Ref to Internal.
Move Value_Type_Helpers to Internal and merge Enso_Types.
distribution/lib/Standard/Table/0.0.0-dev/src/Delimited/Delimited_Format.enso
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make this module private
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used in an Exploratory Benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can run Exploratory Benchmark with --disable-private-check
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Unit Tests pass, then the changes seem ok.
Merged into my PR as 3f24b14 - yes, it solves the FQN != Import problems in |
Pull Request Description
Move the types from
Standard.Table.Data
toStandard.Table
.Exceptions:
Standard.Table.Data.Report_Unmatched
=>Standard.Table.Constants
.Standard.Table.Data.Join_Kind_Cross
=>Standard.Table.Internal.Join_Kind_Cross
.Also removed constructor as an atom type.
Standard.Table.Extensions.Table_Ref
=>Standard.Table.Internal.Table_Ref
.Standard.Table.Data.Type.Value_Type_Helpers
=>Standard.Table.Internal.Value_Type_Helpers
.Standard.Table.Data.Type.Enso_Types
=>Standard.Table.Internal.Value_Type_Helpers
.Standard.Table.Data.Type.Storage
=>Standard.Table.Internal.Storage
.Changed all
Standard.Table
imports inside project to be project.Favoured importing from
Standard.Table.Main
inStandard.Database
.Also fixed some linting in Enso_File.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.