Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Standard.Table. #9559

Merged
merged 19 commits into from
Mar 27, 2024
Merged

Restructure Standard.Table. #9559

merged 19 commits into from
Mar 27, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Mar 27, 2024

Pull Request Description

Move the types from Standard.Table.Data to Standard.Table.

Exceptions:

  • Standard.Table.Data.Report_Unmatched => Standard.Table.Constants.
  • Standard.Table.Data.Join_Kind_Cross => Standard.Table.Internal.Join_Kind_Cross.
    Also removed constructor as an atom type.
  • Standard.Table.Extensions.Table_Ref => Standard.Table.Internal.Table_Ref.
  • Standard.Table.Data.Type.Value_Type_Helpers => Standard.Table.Internal.Value_Type_Helpers.
  • Standard.Table.Data.Type.Enso_Types => Standard.Table.Internal.Value_Type_Helpers.
  • Standard.Table.Data.Type.Storage => Standard.Table.Internal.Storage.

Changed all Standard.Table imports inside project to be project.
Favoured importing from Standard.Table.Main in Standard.Database.
Also fixed some linting in Enso_File.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 27, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to make this module private?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used in an Exploratory Benchmark.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can run Exploratory Benchmark with --disable-private-check.

Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Unit Tests pass, then the changes seem ok.

@jdunkerley jdunkerley added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Mar 27, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Mar 27, 2024
@mergify mergify bot merged commit e262801 into develop Mar 27, 2024
40 of 42 checks passed
@mergify mergify bot deleted the wip/jd/table-data branch March 27, 2024 17:10
@JaroslavTulach
Copy link
Member

Merged into my PR as 3f24b14 - yes, it solves the FQN != Import problems in Standard.Table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants