Replace JSON's Javascript implementation with Jackson one #9591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Jackson_Object` supported parsing but not creating JSON from text. With this change, `Jackson_Object` is on par with `JS_Object` API and can replace the latter. The most visible differences come from more detailed parsing exception's messages.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
jdunkerley,
radeusgd,
GregoryTravis and
AdRiley
as code owners
|
As discussed lets merge into the JS_Object and just have a single Jackson based version. If we need the JS based one later we can always recover. |
jdunkerley
approved these changes
Apr 2, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Json/Extensions.enso
Outdated
Show resolved
Hide resolved
hubertp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Jackson_Objectsupported parsing but not creating JSON from text. With this change,Jackson_Objectis on par withJS_ObjectAPI and replaces the latter.The most visible differences come from more detailed parsing exception's messages. Had to add some special cases for corner cases like
NaNor infinity.Closes #9473.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.