-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expectations in lock manager test #9592
Conversation
The test optimistically assumed that threads will mostly execute in order, while ignoring all other possibilities. This change adds missing expectations. As discovered in https://github.com/enso-org/enso/actions/runs/8516468592/job/23325541262?pr=9584#step:8:1530
Adding @radeusgd in /cc as you wrote the library/tests |
...la/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala
Outdated
Show resolved
Hide resolved
...la/connected-lock-manager/src/test/scala/org/enso/lockmanager/ConnectedLockManagerTest.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the test
I'd just like to correct that I was not 'optimistically' assuming the ordering - the whole purpose of |
Pull Request Description
The test optimistically assumed that threads will mostly execute in order, while ignoring all other possibilities.
Changes the order of the report so that we remove the potential non-determinism.
As discovered in https://github.com/enso-org/enso/actions/runs/8516468592/job/23325541262?pr=9584#step:8:1530
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.