Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vector widget only on vector expressions. #9596

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Apr 2, 2024

Pull Request Description

Fixes #9593

image

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn’t check if it fixes the issue yet

@Frizi Frizi added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Apr 2, 2024
@Frizi
Copy link
Contributor Author

Frizi commented Apr 2, 2024

I did check the described bug scenario, screenshot added.

@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Apr 2, 2024
@mergify mergify bot merged commit 84c8535 into develop Apr 2, 2024
43 of 44 checks passed
@mergify mergify bot deleted the wip/frizi/restrict-vector-widget branch April 2, 2024 13:41
@enso-bot
Copy link

enso-bot bot commented Apr 3, 2024

Paweł Grabarz reports a new STANDUP for yesterday (2024-04-02):

Progress: Fixed vector widget assignment, debugging session on GUI startup through dashboard, demo. It should be finished by 2024-04-02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector editor hides a single value input
2 participants