Interaction resumption #9621
Interaction resumption #9621
Conversation
kazcw
added
the
CI: No changelog needed
app/gui2/src/components/GraphEditor/widgets/WidgetSelection.vue
Outdated
Show resolved
Hide resolved
| widgetId: WidgetId, | ||
| hooks: WidgetEditHooks, | ||
| parent: WidgetEditHandler | undefined, | ||
| portEditor: PortEditor, | ||
| widgetTree: { | ||
| currentEdit: WidgetEditHandler | undefined | ||
| } = injectWidgetTree(), |
There was a problem hiding this comment.
I saw that we use private readonly widgetId: WidgetId syntax in constructor parameters elsewhere, so it's both declared and set as property.
| pointerdown: (event, navigator) => { | ||
| if (!hooks.pointerdown) return false | ||
| return hooks.pointerdown?.(event, navigator) |
There was a problem hiding this comment.
Where the propagation is done?
| readonly active: Ref<boolean> | ||
| private readonly interactionHandler | ||
| private readonly resumable: PortEditResumeData | ||
| private readonly interactions = new Array<PortEditSubinteraction>() |
There was a problem hiding this comment.
What is a difference between PortEditInteraction and PortEditSubinteraction?
| interface Endable { | ||
| end?(origin: WidgetId): void | ||
| } | ||
| /** A child interaction of a @{link PortEditInteraction} */ |
There was a problem hiding this comment.
What is "child interaction"? Is it the same as "child's interaction"? In this page docs, the only parent/child relation is this of Widgets.
| * Obtains a top-level interaction to edit a port (see {@link PortEditInteraction}), which may be a pre-existing | ||
| * ongoing interaction, or a newly-started interaction. */ |
There was a problem hiding this comment.
I think the name does not quite reflect the usage.
|
I rearranged the file to introduce concepts in a more logical order, and added docs, especially to |
| parent: WidgetEditHandler | undefined, | ||
| portEditor: PortEditor, | ||
| widgetTree: { | ||
| private readonly widgetId: WidgetId, |
There was a problem hiding this comment.
Having this, the initializations (lines 57 onwards) are redundant.
Pull Request Description
Prevent interactions such as an open dropdown from being disrupted by the temporary state of absent type information occurring after an edit.
Screen.Recording.2024-04-02.at.06.44.05.mov
All widget-edit interactions that are active when a component is to be unmounted save state and are suspended. When a new component defining a
WidgetEditHandleris instantiated, if the component is found to be equivalent to a component that was suspended, and no other interaction has been initiated in the interim, the interaction is restarted using the suspended state.Important Notes
WidgetEditHandlernow provides a reactiveactiveproperty; using it is simpler and avoids this type of bug in the future.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.