Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store graph viewport in client local storage #9651

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

Frizi
Copy link
Contributor

@Frizi Frizi commented Apr 8, 2024

Pull Request Description

Fixes #6250

With this change, I've also slightly refactored the graph editor component by grouping related functionality into neat block and moving already loosely coupled groups to separate files. Further work will be needed to simplify it, but it is a good first step.

viewport-save.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Frizi Frizi added the -gui label Apr 8, 2024
@Frizi Frizi added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 8, 2024
Comment on lines +393 to +394
// Hide annoying license validation errors in dev mode when the license is not defined. The
// missing define warning is still displayed to not forget about it, but it isn't as obnoxious.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

app/gui2/src/composables/navigator.ts Outdated Show resolved Hide resolved
app/gui2/src/composables/navigatorStorage.ts Outdated Show resolved Hide resolved
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label Apr 9, 2024
@mergify mergify bot merged commit 4bf7977 into develop Apr 9, 2024
36 of 37 checks passed
@mergify mergify bot deleted the wip/frizi/preserve-camera branch April 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After saving and reopening project the camera settings are not preserved
2 participants