On MacOS, do not assume existence of Contents/Home
in the JDK binary path
#9684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when looking for the
java
executable on MacOS, we assume that it's under$root/Contents/Home/bin
. On my M1 (running Monterey 12.6.3), using sdkman, there is noContents/Home
between$root
andbin
.This change checks for the binary under
Contents/Home/bin
, and if it doesn't exist, defaults back to justbin
.I suspect that this depends on the OS version.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.