Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node placement #9696

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix node placement #9696

merged 1 commit into from
Apr 15, 2024

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Fixes #9689

We should consider visualization size in all cases. visibleArea has multiple usages, but they all seem to benefit from the change (e.g. zoom to selected will also consider visualization sizes).

fixed.node.placement.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 15, 2024
@vitvakatu vitvakatu self-assigned this Apr 15, 2024
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Apr 15, 2024
@mergify mergify bot merged commit 59a9c8e into develop Apr 15, 2024
36 of 37 checks passed
@mergify mergify bot deleted the wip/vitvakatu/node-placement branch April 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node created while another node is selected is not placed under.
2 participants