Implement recursive argument for File.delete
#9719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
radeusgd
commented
Apr 16, 2024
Comment on lines
-119
to
-140
| group_builder.specify "should not allow to create a directory inside of a regular file" <| | ||
| test_file = test_root.get / "test_file.json" | ||
| test_file.exists . should_be_true | ||
|
|
||
| r = test_file.create_directory "my_test_dir" | ||
| r.should_fail_with Illegal_Argument | ||
|
|
||
| # TODO expand with #8993 | ||
| group_builder.specify "should delete all contents of a directory when deleting a directory" <| | ||
| dir1 = test_root.get.create_directory "my_test_dir1"+(Random.uuid.take 5) | ||
| dir1.should_succeed | ||
|
|
||
| dir2 = dir1.create_directory "my_test_dir2" | ||
| dir2.should_succeed | ||
|
|
||
| dir1.delete . should_succeed | ||
|
|
||
| Test.with_retries <| | ||
| dir1.exists . should_be_false | ||
| # The inner directory should also have been trashed if its parent is removed | ||
| dir2.exists . should_be_false | ||
|
|
There was a problem hiding this comment.
These tests were replaced with Local_File_Spec.add_create_and_delete_directory_specs
radeusgd
commented
Apr 16, 2024
There was a problem hiding this comment.
I recommend to look at these changes with 'Hide whitespace changes'
GregoryTravis
approved these changes
Apr 16, 2024
| delete : Boolean -> Nothing | ||
| delete self (recursive : Boolean = False) = | ||
| # TODO improve recursive deletion for S3 folders: https://github.com/enso-org/enso/issues/9704 | ||
| if self.is_directory then Error.throw (S3_Error.Error "Deleting S3 folders is currently not implemented." self.uri) else |
There was a problem hiding this comment.
It looks like S3 folder deletion is implemented in delete_if_exists, why is it different here?
There was a problem hiding this comment.
Good point, I removed that and rephrased the TODO
Akirathan
approved these changes
Apr 17, 2024
This reverts commit e284d7c
jdunkerley
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
recursiveoption forFile.delete#8993Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.