Selection panel #9771
Merged
Selection panel #9771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
CI: No changelog needed
Frizi
approved these changes
Apr 23, 2024
| @@ -581,6 +591,7 @@ const groupColors = computed(() => { | |||
| :allowNavigationLeft="stackNavigator.allowNavigationLeft.value" | |||
| :allowNavigationRight="stackNavigator.allowNavigationRight.value" | |||
| :zoomLevel="100.0 * graphNavigator.targetScale" | |||
| :componentsSelected="nodeSelection.selected.size" | |||
There was a problem hiding this comment.
At this point it would probably make sense to make TopBar actually use the context variables directly, instead of passing so much data through props and events. Doesn't have to be done in this PR, but it is worth to clean it up at some point to cut down on GraphEditor rerenders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9519
Screencast.from.2024-04-23.12-57-01.webm
Important Notes
I decided to go against our refinement notes, as in the action the blinking does not look bad, and seeing "live" how many nodes are selected may be useful.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.