Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table running variance skew sd and kurtosis #9854

Merged
merged 4 commits into from
May 9, 2024
Merged

Add table running variance skew sd and kurtosis #9854

merged 4 commits into from
May 9, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented May 3, 2024 •
edited
Loading

Pull Request Description

Adds support for Variance, Skew, Standard Deviation and Kurtosis to Table.Running.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley changed the base branch from develop to wip/adr/table-running-min-max-for-ints May 3, 2024 10:19
@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label May 3, 2024
Base automatically changed from wip/adr/table-running-min-max-for-ints to develop May 7, 2024 09:49
@AdRiley AdRiley force-pushed the wip/adr/add-table-running-variance-skew-sd-kurtosis branch from c071550 to 495db58 Compare May 7, 2024 10:41
@AdRiley AdRiley changed the title Wip/adr/add table running variance skew sd kurtosis Add table running variance skew sd and kurtosis May 7, 2024
@AdRiley AdRiley marked this pull request as ready for review May 7, 2024 10:43
jdunkerley
jdunkerley approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - would like to use Sample and Population for the Java names but otherwise good.

distribution/lib/Standard/Base/0.0.0-dev/src/Data/Statistics.enso Outdated Show resolved Hide resolved
@AdRiley AdRiley added the CI: Ready to merge This PR is eligible for automatic merge label May 9, 2024
@mergify mergify bot merged commit e25ec96 into develop May 9, 2024
35 checks passed
@mergify mergify bot deleted the wip/adr/add-table-running-variance-skew-sd-kurtosis branch May 9, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdRiley @jdunkerley @GregoryTravis