Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from conversion propagates dataflow error #9856

Merged
merged 2 commits into from
May 3, 2024
Merged

from conversion propagates dataflow error #9856

merged 2 commits into from
May 3, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented May 3, 2024 •
edited
Loading

Fixes #9669

Pull Request Description

Just add a dataflow error sentinel specialization to InvokeConversionNode.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@Akirathan Akirathan self-assigned this May 3, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label May 3, 2024
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label May 3, 2024
@mergify mergify bot merged commit 2af217c into develop May 3, 2024
37 of 38 checks passed
@mergify mergify bot deleted the wip/akirathan/9669-from-propagate-dataflow-error branch May 3, 2024 14:48
@enso-bot enso-bot bot mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@Akirathan Akirathan

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

from conversion does not propagate dataflow error
3 participants
@Akirathan @jdunkerley @JaroslavTulach