Language server needs java.desktop and java.se modules #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
CI: Ready to merge
JaroslavTulach
requested review from
radeusgd,
AdRiley,
jdunkerley,
GregoryTravis and
Cassandra-Clark
|
This issue was discussed yesterday at #9113 (comment) - it should have strike me that the language server execution would be affected. |
radeusgd
approved these changes
May 8, 2024
|
Thanks this fixes the issue on Windows. |
jdunkerley
approved these changes
May 8, 2024
hubertp
approved these changes
May 8, 2024
|
Oh, so it also fixes #9876 |
|
I have created a PR for If that change gets in, we'll be able to switch to new version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes regression introduced by #9868 - language server still needs dependency on
java.desktopandjava.se.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,