Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup placement unit tests #9943

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

While fixing prop test in #9916, I was surprised to see a lot of basically unused checks in unit tests. With the new API, the need for them is gone.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@vitvakatu vitvakatu added CI: No changelog needed Do not require a changelog entry for this PR. x-chore Type: chore -gui labels May 14, 2024
@vitvakatu vitvakatu self-assigned this May 14, 2024
@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label May 14, 2024
@mergify mergify bot merged commit 557d585 into develop May 14, 2024
38 checks passed
@mergify mergify bot deleted the wip/vitvakatu/cleanup-placement-tests branch May 14, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-chore Type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants