This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
CI Improvements #1175
Merged
CI Improvements #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
approved these changes
Feb 4, 2021
MichaelMauderer
approved these changes
Feb 4, 2021
| const NODE_VERSION = '14.15.0' | ||
| const RUST_VERSION = 'nightly-2019-11-04' | ||
| const WASM_PACK_VERSION = '0.9.1' | ||
| const NODE_VERSION = '14.15.0' |
There was a problem hiding this comment.
Are we not getting this version programmatically somewhere?
There was a problem hiding this comment.
Good question and good observation. Yes, we repeat things in CI, we always did. I'll add a task to fix it, but it will take some good refactoring one day.
mwu-tow
pushed a commit
to enso-org/enso
that referenced
this pull request
Oct 30, 2021
Original commit: enso-org/ide@0eadf27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
CHANGELOG.mdwas modified. See docs for more info and options.sha256checksum generation..zipoutputs from electron-builder. Zip archives were of almost the same size (saving of <3Mb) than the whole package and their generation was long. Other types, like.tar.gzdo not save much and their generation is even longer (which probably is also broken in electron-builder, as the generation of.tar.gzcan take literally hours!).