Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception being raised when start_feature request handling fails #10

Merged

Conversation

mgreen89
Copy link

@mgreen89 mgreen89 commented Jul 6, 2020

Arguments are not always strings (e.g. when handling a start_feature request, one of the arguments is the original request dict), so convert to strings before concatenation.

Copy link
Contributor

@simonchatts simonchatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks Matt!

@simonchatts simonchatts merged commit 3648d14 into ensoft:master Jul 6, 2020
@simonchatts
Copy link
Contributor

Updated version now on PyPI

@mgreen89 mgreen89 deleted the bugfix/feature-start-fail-debug branch July 6, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants