Upgrade node and ethers #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicodelatorre7
force-pushed
the
upgrade-node-and-ethers
branch
3 times, most recently
from
af1d3d3
to
9e571ad
Compare
nicodelatorre7
force-pushed
the
upgrade-node-and-ethers
branch
from
9e571ad
to
c12475d
Compare
1. Fix Dockerfile fixing Node to 20 and changing to Python 3.10 2. Change prettier settings to use 120 line size for solidity files as specified in official style-guide 3. Run prettier with the new settings (many .sol changes) 4. Upgrade pre-commit-config becase we were using non staged versions. 5. Run pre-commit on all files and fix issues found. 6. Remove .solcover.js since is no longer used 7. Disable solhint for mocks folder
gnpar
reviewed
Feb 26, 2024
| "SignedBucketRiskModule: bucketId can't be zero, set default RM parameters" | ||
| ); | ||
| function deleteBucket(uint256 bucketId) external onlyGlobalOrComponentRole2(LEVEL1_ROLE, LEVEL2_ROLE) { | ||
| require(bucketId != 0, "SignedBucketRiskModule: bucketId can't be zero, set default RM parameters"); |
There was a problem hiding this comment.
Big readability improvement here!
1. Fixes some comments in solidity code 2. Fix typo in deploy.js 3. Remove .address and .target when possible (WIP)
Also, it would be useful in other packages
gnarvaja
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.